Fix security vulnerabilities in docs site #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoek v2.16.3 has a security vulnerability. Browser-sync and node-sass were both dependent on this package. I've updated browser-sync to the latest version. Regarding node-sass, there is not currently a released version that fixes this vulnerability. They plan on deploying a fix in version 5, which is supposedly coming in a few weeks. I've gone ahead and upgraded us to the v5 branch of node-sass for the time being; this removes our dependency on Hoek, while still allowing the project to build.
gmacdougall
approved these changes
May 28, 2018
tvdeyen
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoek v2.16.3 has a security vulnerability. Browser-sync and node-sass were both dependent on this package. I've updated browser-sync to the latest version. Regarding node-sass, there is not currently a released version that fixes this vulnerability. They plan on deploying a fix in version 5, which is supposedly coming in a few weeks. I've gone ahead and upgraded us to the v5 branch of node-sass for the time being; this removes our dependency on Hoek, while still allowing the project to build.