Remove promotions admin UI that misleadingly doesn't do anything on the solidus_frontend #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
May 16, 2018
|
I am under the impression that the changelog was just generated from commit messages, except for the major changes block for each version. |
While making promotions advertisable is a good feature, the "Advertise" checkbox doesn't do anything when using `solidus_frontend` and `solidus_backend` out of the box. There also isn't a clear path forward for how developers should use this feature. Where should promotions be advertised? How should complex promotions be advertised? Developers can implement custom promotion advertisement features by using the `advertise` attribute on `Spree::Promotion`s, but keeping this in the UI isn't helpful. Let's consider re-adding this to the UI if we can make the usage cleared and working in the default `solidus_frontend` configuration.
While having a promotion activate when the customer reaches a path is a great feature idea, this this activation type is not actually wired up to anything. If a store admin tried to set up a path-activated promotion, it would not work. This also does not provide a clear path forward for developers trying to set up a feature like this. This feature may be a good candidate for an extension with additional documentation.
benjaminwil
force-pushed
the
backend/promotions/form
branch
from
c66476c
to
d2b6516
Compare
gmacdougall
approved these changes
May 29, 2018
This was referenced Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the UI I am removing are candidates for useful features, these features are not actually implemented or working on the
solidus_frontend. I also do not think that the UI really "helps" developers who may want to implement these features or features like them.I think that we should remove these UI elements for now because they mislead store administrators. When we re-add them to the admin UI, we should make sure that developers have a clear path forward for implementing the features.