Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require sass >= 3.5.2 #2734

Merged
merged 1 commit into from
May 15, 2018
Merged

Conversation

gmacdougall
Copy link
Member

Bootstrap 4.x requires at least sass 3.5.2.

For more information see:
twbs/bootstrap-rubygem#122
sass/sass#2383

Bootstrap 4.x requires at least sass 3.5.2.

For more information see:
twbs/bootstrap-rubygem#122
sass/sass#2383
Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed? Doesn’t bundler resolve this automatically for us?

In order to support SassC (a much faster, C based Sass implementation) we should actually remove the sass and sass-rails dependencies from our gemspecs and tell our users to add the Sass implementation of their liking.

@gmacdougall
Copy link
Member Author

Right now we don't have a specific sass version requirement so bundler will resolve to any version of sass. We require 3.5.2 or greater due to the issues linked.

@jhawthorn
Copy link
Contributor

In order to support SassC (a much faster, C based Sass implementation) we should actually remove the sass and sass-rails dependencies from our gemspecs and tell our users to add the Sass implementation of their liking.

I think this still works with both included. sassc-rails even depends on sass

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying

@gmacdougall gmacdougall merged commit b9cab08 into solidusio:master May 15, 2018
@gmacdougall gmacdougall deleted the require-sass-3.5.2 branch May 15, 2018 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants