Negative coh red #2682
Merged
Negative coh red #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Apr 6, 2018
| } | ||
| } | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Could we move this in its own file? Then this is more easily adjustable by stores.
| @@ -98,6 +98,8 @@ dl { | |||
| .red { color: $color-5 } | |||
| .yellow { color: $color-6 } | |||
|
|
|||
| .negative { color: $color-5 !important } | |||
There was a problem hiding this comment.
Could we use a meaningful color variable (we have $red) here?
There was a problem hiding this comment.
Do we really need the !important here? Especially with this generic class this could cause headaches. Would a stronger selector like
input[type="number"].negativework as well?
| document.querySelector('body').addEventListener('input', function(e){ | ||
| var el = e.target; | ||
| var isInputNumber = el instanceof HTMLInputElement && el.type == 'number'; | ||
| if(isInputNumber){ |
There was a problem hiding this comment.
Could we please the human eye by adding some spacing here?
| var el = e.target; | ||
| var isInputNumber = el instanceof HTMLInputElement && el.type == 'number'; | ||
| if(isInputNumber){ | ||
| if(el.value < 0){ |
|
Note to self. Enable javascript syntax linting on HoundCI |
This commit aims to smooth out admin user interactions when dealing with number by providing visual feedback of negative numbers Having negative amounts of items is unintuitive, though necessary for backordering. This commit calls out when a number is negative by highlighting it in red.
|
Requested changes made, thanks! |
gmacdougall
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the user experience of the admin, specifically with the goal of alleviating the #2530. Since we do not know if generally admins prefer to get setting the count on hand (as they do now), or would rather mostly be adjusting it instead, this PR aims instead to provide the admin better visual feedback such that they are more aware when the number they are dealing with is negative or not.