Disable backend footer profile edit link if role cannot edit users #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cringegnere
force-pushed
the
add-edit-user-backend-permission-check
branch
3 times, most recently
from
12bcadc
to
3e31fdb
Compare
kennyadsl
requested changes
Mar 26, 2018
| @@ -6,16 +6,39 @@ | |||
| let(:user) { FactoryBot.build_stubbed(:admin_user) } | |||
| before do | |||
| allow(view).to receive(:try_spree_current_user).and_return(user) | |||
| @ability = Object.new.extend(CanCan::Ability) | |||
There was a problem hiding this comment.
I think this can be a let outside the before block
| @@ -6,16 +6,39 @@ | |||
| let(:user) { FactoryBot.build_stubbed(:admin_user) } | |||
| before do | |||
| allow(view).to receive(:try_spree_current_user).and_return(user) | |||
| @ability = Object.new.extend(CanCan::Ability) | |||
| allow(@controller).to receive(:current_ability).and_return(@ability) | |||
There was a problem hiding this comment.
I think @controller can be called as controller without the @ here.
| expect(rendered).to have_link(user.email, href: Spree::Core::Engine.routes.url_helpers.edit_admin_user_path(user)) | ||
| context "authorized user" do | ||
| it "has a user-account-link that links to edit_admin_user_path" do | ||
| @ability.can :admin, user |
There was a problem hiding this comment.
you can move this ability setting in a before that lives into the context authorized user since it will be applied to all its scenarios.
cringegnere
force-pushed
the
add-edit-user-backend-permission-check
branch
from
3e31fdb
to
4d61048
Compare
jhawthorn
reviewed
Apr 5, 2018
| <%= try_spree_current_user.email %> | ||
| <% end %> | ||
| <% else %> | ||
| <%= link_to spree.admin_path do %> |
There was a problem hiding this comment.
I'm not sure it makes sense to link to the root. Maybe we should drop the link entirely (just plain text) if we don't have permissions?
cringegnere
force-pushed
the
add-edit-user-backend-permission-check
branch
from
4d61048
to
faa64d8
Compare
cringegnere
force-pushed
the
add-edit-user-backend-permission-check
branch
from
faa64d8
to
5b64046
Compare
|
I think it's all okay now |
kennyadsl
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user with a role that can access the backend main page but has no permissions to edit users will get a misleading "Authorization Failure" error.
With this fix the user will be cleanly routed to the main page without displaying any errors.