Allowing admin to show all countries regardless checkout zone #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Feb 20, 2018
| @@ -106,8 +106,8 @@ def taxons_tree(root_taxon, current_taxon, max_level = 1) | |||
| end | |||
| end | |||
|
|
|||
| def available_countries | |||
| checkout_zone = Zone.find_by(name: Spree::Config[:checkout_zone]) | |||
| def available_countries(zone_name = Spree::Config[:checkout_zone]) | |||
There was a problem hiding this comment.
I would like to have a more meaningful parameter here. Just passing nil to restrict the countries to a specific zone seams unintuitive to me.
Maybe something like?
def available_countries(restrict_to_zone: Spree::Config[:checkout_zone])
softr8
force-pushed
the
replace-backend-checkout-zone
branch
from
2f8efc8
to
27eec5b
Compare
softr8
force-pushed
the
replace-backend-checkout-zone
branch
from
27eec5b
to
9d6722c
Compare
|
Done! let me know if it still makes sense. Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2562