Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frozen_string_literal: true to all files #2586

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

jhawthorn
Copy link
Contributor

Also remove any encoding: UTF-8 comments which should no longer have any effect.

Also remove any encoding: UTF-8 comments which should no longer have any
effect.
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Out of curiosity did you test how much memory actually gets saved on a regular store?

@jhawthorn
Copy link
Contributor Author

Nice. Out of curiosity did you test how much memory actually gets saved on a regular store?

I haven't, and I'm not sure what exactly I would measure (maybe run stack_prof or memory_prof on a full checkout?). I'm not expecting a major improvement (but would love to be surprised by one).

Copy link
Member

@gmacdougall gmacdougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't expect that memory improvements will be the major win here, but consistent behaviour between this and the upcoming Ruby 3.0 is definitely desired.

@jhawthorn jhawthorn merged commit 859143f into solidusio:master Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants