Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutable false to default refund reason record #2574

Conversation

mdesantis
Copy link
Contributor

Fixes #2573

@mdesantis mdesantis force-pushed the add-mutable-false-to-default-refund-reason-record branch from 2e6005d to f5e847c Compare February 14, 2018 16:06
@mdesantis mdesantis force-pushed the add-mutable-false-to-default-refund-reason-record branch from f5e847c to e65c00a Compare February 14, 2018 16:10
@kennyadsl
Copy link
Member

In another PR we could remove this mutable thing, if it's just used to do not allow admin to change its name (since it has to be the same of the constant defined here) in favor of a default boolean on the refund reason table. WDYT?

@mdesantis
Copy link
Contributor Author

mdesantis commented Feb 14, 2018

If the mutablething is used just to mark the default record yes, it shouldn't be much more complex than rename mutable to default and swap the values; if otherwise the mutable thing is there to represent some separated logic we could add a default column in order to manage this record and leave the mutable thing alone.

@jhawthorn jhawthorn added this to the 2.5.0 milestone Feb 15, 2018
@jhawthorn
Copy link
Contributor

Thank you!

@jhawthorn jhawthorn merged commit 9b50da4 into solidusio:master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants