Add store promotion rule #2552
Merged
Add store promotion rule #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 2, 2018
| promotable.is_a?(Spree::Order) | ||
| end | ||
|
|
||
| def eligible?(order, options = {}) |
There was a problem hiding this comment.
Unused method argument - options. If it's necessary, use _ or _options as an argument name to indicate that it won't be used.
Introduces a new promotion rule (originally part of `solidus_multi_domain`) that allows for scoping promotions to specific stores.
jhawthorn
reviewed
Feb 5, 2018
| end | ||
|
|
||
| def eligible?(order, _options = {}) | ||
| stores.none? || stores.include?(order.store) |
There was a problem hiding this comment.
it seems really weird to check stores.none? here
There was a problem hiding this comment.
It is a little odd. I'm not sure why it was originally written this way in solidus_multi_domain, but I figured it would be best to keep it the same.
jhawthorn
approved these changes
Feb 5, 2018
kennyadsl
approved these changes
Feb 9, 2018
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new promotion rule (originally part of
solidus_multi_domain) that allows for scoping promotions to specific stores.