Allow selecting admin-only shipping methods #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capybara can find the element
jhawthorn
force-pushed
the
admin_only_shipping_methods
branch
from
e0a8678
to
3239735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating shipping rates, the standard behaviour is to calculate the rates using the
Stock::Estimatorand persist the results asShippingRates. The user then selects their desired rate.This behaviour falls apart when we want to have some shipping rates available only to admins. We don't want to persist those rates because it would make them available to users.
This PR solves the issue by introducing two new api endpoints:
The new
estimated_ratesendpoint will re-run the estimator and return the rates (including admin-only rates) without persisting them.The
select_shipping_methodendpoint will re-run the estimator and persist only the specified rate, marking it as selected. This allows selecting admin-only rates.The order shipments page has been updated to use these endpoints instead of relying on persisted shipping rates.
Fixes #1711