Replace new product inline form with normal form #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, creating a new product involved filling out a small inline form which held with only the required attributes of a product. This requires admin users to understand and learn to use two separate forms with the same purpose (filling in product data). It's also awkward if the user wants to fill in some of the information not on this page as they have to create the product. This commit removes the inline new product form in favour of linking to a new product page with the same form as the edit page.
Slug is generated automatically if empty
jhawthorn
force-pushed
the
new_product
branch
from
1b04005
to
c9adade
Compare
|
A compromise required to make this work: the slug field needs to be disabled when creating a new product in order to keep the behaviour we had previously (slug generated on create, slug required when updating). I think this is a reasonable solution and we can address it later if there is a preferred UX design. |
|
Great work John! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, creating a new product involved filling out a small inline form which held with only the required attributes of a product.
This requires admin users to understand and learn to use two separate forms with the same purpose (filling in product data). It's also awkward if the user wants to fill in some of the information not on this page as they have to create the product and then fill in the rest of the information they cared about.
This commit removes the inline new product form in favour of linking to a new product page with the same form as the edit page.
Before:
After:
Todo:
Specifying slug doesn't work on a new productIt does work, but is cleared if validations fail due to a bug in friendly_id, which I will file thereShould we add the tabs? Disabled?Can't render. We can revisit if this is important