Update totals after order_with_totals create #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 22, 2017
| @@ -27,6 +27,10 @@ | |||
| price: evaluator.line_items_price | |||
| ) | |||
| end | |||
|
|
|||
| after(:create) do |order, evaluator| | |||
There was a problem hiding this comment.
Unused block argument - evaluator. If it's necessary, use _ or _evaluator as an argument name to indicate that it won't be used.
BravoSimone
force-pushed
the
fix-order-with-totals-factory
branch
from
de2f5d3
to
73edccd
Compare
kennyadsl
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding an
after :createhook in the order_with_totals factory callingorder.recalculateto update totals.I'm not 100% sure having a different behaviour between
createandbuildis correct.ref #2389