Use I18n date format for pretty_time helper
#2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
prettier-time
branch
from
ce4402d
to
9e33e87
Compare
|
Build errors will be fixed by #2423 |
Instead of concatinating strings we should use a i18n date format instead.
Instead of only using a long version we add a short version too. You can add your own solidus time format by adding a format to
your-locale:
time:
formats:
solidus:
iso: '%F'
and use it with `pretty_time(record.created_at, :iso)`.
tvdeyen
force-pushed
the
prettier-time
branch
from
9e33e87
to
40c7ee5
Compare
jhawthorn
approved these changes
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of concatenating strings we should use a
i18ndate format instead.Also introduces support for custom Solidus' time formats. Currently we are using the Rails
:longdate format that Rails apps and extensions might override. Instead we use our ownsolidusnamespace to avoid conflicts.