Admin order payments ui cleanup #2411
Conversation
tvdeyen
added
changelog:solidus_backend
| <div class="input-group-addon number-with-currency-symbol"> | ||
| <%= ::Money::Currency.find(@order.currency).symbol %> | ||
| </div> | ||
| <%= number_field_tag :amount, payment.amount, class: 'js-edit-amount align-right form-control', step: :any %> |
There was a problem hiding this comment.
We decided to use "text" input for currency fields, right?
There was a problem hiding this comment.
Oh, yes. This is a left over from my investigation. Thanks! Will fix that
tvdeyen
force-pushed
the
admin-order-payments-ui
branch
from
625220e
to
819bdad
Compare
| @@ -0,0 +1,24 @@ | |||
| Spree.Views.Payment.PaymentRow = Backbone.View.extend | |||
There was a problem hiding this comment.
I think the file should be in javascript instead coffee.
From backend README:
Though we have existing CoffeeScript files, any new files should be in javascript (ES5).
There was a problem hiding this comment.
Ah, you are right, good catch!
|
|
||
| onEdit: (e) -> | ||
| e.preventDefault() | ||
| @$el.addClass("editing") |
There was a problem hiding this comment.
Surely is outside the scope of this changes.
But we have similar backbone views that use a conditional value editing with a handlebars template. (ex: orders/shipping_methods) I think that approach is better than show/hide with css.
Maybe we can create a common view for use in this cases.
There was a problem hiding this comment.
Absolutely. Will see if I can sneak this into this PR
After going full house bootstrap the form looks a little off. This re-structures the form so it fits better into the admin interface.
All our backbone views live in the spree/backend/views folder. Also uses our Spree javascript object to store the instance instead of a global.
Instead of defining the model everytime we render the payment screen we define a model in the spree/backend/models folder and initialize that when we render the payments screen.
The amount needs a min-width in order to not be too small in narrow areas. One might not be able to see the value. The addon shoud not have a fixed width, but a min-width so it grows when necessary, but not take too much space it actually does not need.
We sometimes want to vertically align table rows to the middle, not to the top as we do by default now. This new class allows to do so.
It is ok to just call this state "State" instead of "Payment State". We use this attribute in lots of tables and the space is limited.
The order payments table has lots of information and lacks some structure. By moving the amount to the right of the table and give it some as well as align it to the right this important piece of information is now better visible. If a user wants to change the amount of an uncaptured payment the form is now right by the action icons and not somewhere in the middle. By further shorten the creation date format we gain some valuable extra space.
Per our definition newly introduced files should be JS instead of Coffeescript.
tvdeyen
force-pushed
the
admin-order-payments-ui
branch
from
819bdad
to
3d135fe
Compare
|
@kennyadsl made the requested changes |
Extracted from #2255
Made some changes to the admin order payments UI:
Screenshots