Deprecate class method in Calculator::FlexiRate
#2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class method is not used anywhere in the code base. As a calculator, the `available?` method should in general be an instance method (which defaults to `true` from the inherited base calculator class). I can't go back far enough in the history of the source code to find out why this method was added in the first place.
jhawthorn
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class method is not used anywhere in the code base. As a
calculator, the
available?method should in general be an instancemethod (which defaults to
truefrom the inherited base calculator class).I can't go back far enough in the history of the source code to find out
why this method was added in the first place.