update no_objects_found partial to allow not show new resource link #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
requested changes
Oct 25, 2017
| @@ -1,4 +1,4 @@ | |||
| <%= Spree.t(:no_resource, resource: plural_resource_name(resource)) %> | |||
| <% if can? :create, resource %> | |||
| <% if can? :create, resource and !new_resource_url.nil? %> | |||
There was a problem hiding this comment.
We should use local_assigns here to make it optional.
if can?(:create, resource) && local_assigns[:new_resource_url]There was a problem hiding this comment.
Yeah, is more clean like you propose 👍
I'll update the pulll request accordingly
| @@ -41,7 +41,7 @@ | |||
| <div class="col-9 no-objects-found"> | |||
| <%= render 'spree/admin/shared/no_objects_found', | |||
| resource: Spree::StockMovement, | |||
| new_resource_url: new_object_url %> | |||
| new_resource_url: nil %> | |||
There was a problem hiding this comment.
We can remove this local entirely if we use local_assigns in the partial above.
firmanm
pushed a commit
to firmanm/solidus
that referenced
this pull request
Nov 27, 2017
update no_objects_found partial to allow not show new resource link solidusio#2289
|
Sorry that this took so long. Please feel free to ping us, if it takes too long for an approved PR to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2150
Like described in the issue mentioned above there is an error when we try to generate a
new_object_urlfor stock movements, this because stock movements only allow index route.