Replace frontend jquery validations with html5 #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Oct 25, 2017
jhawthorn
changed the title
Also only "require" it if its required in the schema.
Its a nice-to-have, but we validate it in the backend and the accompanying javascript is too zaney to want to deal with here.
As we've switched to html5 vlaidations, this is no longer necessary.
We have validations now, so we need it.
When other payment options (or methods) are rendered, these fields might not be used, but it would block the submission of the form. We're opting to rip this out entirely and leaving it up to stores. They can include jquery-validate, ignore this, or handle it otherwise.
jhawthorn
force-pushed
the
html5-validations-1548-rebase
branch
from
ed6fadc
to
f010939
Compare
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Nov 22, 2017
We didn't have required on lastname before solidusio#2264. Also, we don't need the required span with * since that field is not actually required.
This was referenced Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rebases #1548 to remove the pattern regex (which we don't expect to get right), and kill the validations on the state (which is checked in the backend and too complicated to do right in this PR).