Deprecate AdjustmentSource#deals_with_adjustments_for_deleted_source #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop setting spree_adjustments.source_id to null on completed orders when deleting an adjustment source. This shouldn't be necessary since in either case `adjustment.source` will be nil. Also, the two sources using this within Solidus itself (PromotionAction and TaxRate) both use `acts_as_paranoid` so deleting the source_id deletes data that could still be useful because the record is still actually in the database.
cbrunsdon
force-pushed
the
deals-with-deals-with-1419-rebase
branch
from
8568442
to
d63e06e
Compare
gmacdougall
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop setting spree_adjustments.source_id to null on completed orders
when deleting an adjustment source.
This shouldn't be necessary since in either case
adjustment.sourcewill be nil. Also, the two sources using this within Solidus itself
(PromotionAction and TaxRate) both use
acts_as_paranoidso deletingthe source_id deletes data that could still be useful because the
record is still actually in the database.
Rebase of #1419