Do a solidus 1.4 roll-up migration #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrunsdon
force-pushed
the
migration_rollup
branch
2 times, most recently
from
5752283
to
b84f120
Compare
houndci-bot
reviewed
Sep 19, 2017
| t.integer "ship_address_id" | ||
| t.integer "bill_address_id" | ||
| t.datetime "created_at", :null => false | ||
| t.datetime "updated_at", :null => false |
| t.string "login" | ||
| t.integer "ship_address_id" | ||
| t.integer "bill_address_id" | ||
| t.datetime "created_at", :null => false |
| t.string "single_access_token" | ||
| t.string "perishable_token" | ||
| t.integer "login_count", :default => 0, :null => false | ||
| t.integer "failed_login_count", :default => 0, :null => false |
| t.string "persistence_token" | ||
| t.string "single_access_token" | ||
| t.string "perishable_token" | ||
| t.integer "login_count", :default => 0, :null => false |
| # and creates a table equivolent to it | ||
| create_table "spree_users", :force => true do |t| | ||
| t.string "crypted_password", :limit => 128 | ||
| t.string "salt", :limit => 128 |
| # but spree_api depends on it existing. This defininition comes from solidus_auth_devise's first migration, | ||
| # and creates a table equivolent to it | ||
| create_table "spree_users", :force => true do |t| | ||
| t.string "crypted_password", :limit => 128 |
| # this table should not technically exist in the database (as its provided by auth_devise), | ||
| # but spree_api depends on it existing. This defininition comes from solidus_auth_devise's first migration, | ||
| # and creates a table equivolent to it | ||
| create_table "spree_users", :force => true do |t| |
cbrunsdon
force-pushed
the
migration_rollup
branch
from
b84f120
to
9d13257
Compare
The logical break between solidus 1.4 and 2.0 means we can take some liberties with some clean up in a pretty safe way. This rolls up the migrations (something we haven't done for the last 5 years), cleaning up our migration directory and importing fewer migrations into new stores. It also has the added benefit of not needing to run through the entire migration history for a test_app, or having to maintain any of the old migrations. Like the spree_one_two rollup, I had to include a definition of spree_users even though it shouldn't be part of core's schema.
cbrunsdon
force-pushed
the
migration_rollup
branch
from
9d13257
to
59bf348
Compare
tvdeyen
reviewed
Sep 20, 2017
| # this table should not technically exist in the database (as its provided by auth_devise), | ||
| # but spree_api depends on it existing. This defininition comes from solidus_auth_devise's first migration, | ||
| # and creates a table equivolent to it | ||
| create_table "spree_users", force: true do |t| |
There was a problem hiding this comment.
Can't we fix solidus_api instead? It should not rely on this table.
There was a problem hiding this comment.
Discussed IRL, not reasonable to do with this PR (which doesn't change behavior). We'll need to change behavior to fix it elsewhere.
tvdeyen
approved these changes
Sep 20, 2017
mamhoff
approved these changes
Sep 20, 2017
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Nov 25, 2017
Also, we are not creating a store in migrations since solidusio#2229, but populating database with default data and sample data (for example creating the sandbox) is creating two different stores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logical break between solidus 1.4 and 2.0 means we can take some
liberties with some clean up in a pretty safe way.
This rolls up the migrations (something we haven't done for the last 5
years), cleaning up our migration directory and importing fewer
migrations into new stores.
It also has the added benefit of not needing to run through the entire
migration history for a test_app, or having to maintain any of the old
migrations.