Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove identical inheritied methods in Spree::StoreCredit #2200

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Remove identical inheritied methods in Spree::StoreCredit #2200

merged 1 commit into from
Sep 6, 2017

Conversation

swcraig
Copy link
Contributor

@swcraig swcraig commented Sep 1, 2017

The implementations of these methods are identical to the ones defined
in the superclass Spree::PaymentSource.

The implementations of these methods are identical to the ones defined
in the superclass `Spree::PaymentSource`.
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a safe removal to make. 👍

@cbrunsdon cbrunsdon merged commit f4fb3a5 into solidusio:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants