Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove autoload on product_filters #2190

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Remove autoload on product_filters #2190

merged 1 commit into from
Sep 6, 2017

Conversation

cbrunsdon
Copy link
Contributor

@cbrunsdon cbrunsdon commented Aug 30, 2017 •
edited
Loading

I'm almost positive this does nothing.

EDIT: it did something. but not that much.

Remove autoload on product_filters
f2c37fe 
I was pretty sure it did nothing. It turns out it did *almost* nothing.
@cbrunsdon cbrunsdon force-pushed the remove_product_filter_autoload branch from 9f71609 to f2c37fe Compare August 30, 2017 02:20
tvdeyen
tvdeyen approved these changes Aug 30, 2017
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did it?

@cbrunsdon
Copy link
Contributor Author

I thought I could remove the autoload, but I also needed to add the require.

@cbrunsdon cbrunsdon merged commit f82567f into solidusio:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbrunsdon @tvdeyen