Wrap Splitter chaining behaviour in new Stock::SplitterChain class #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These attributes were already declared on the superclass
houndci-bot
reviewed
Aug 29, 2017
| class SplitterChain | ||
| attr_reader :stock_location | ||
|
|
||
| def initialize(stock_location, splitter_classes=[]) |
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
Previously the Stock::Packer was responsible for building a chain of Splitter objects to split objects after packaging. This required some precise behaviour (like order of initialization) as well as edgecase handling (empty array of splitters) which wasn't well tested and should be outside the responsibilities of the Packer itself. This extracts the behaviour to Spree::Stock::SplitterChain, which handles building and calling the splitters.
jhawthorn
force-pushed
the
splitter_chain
branch
from
1c4adbd
to
ccf1194
Compare
Previously, Splitters were tightly coupled to Stock::Packer without good reason. None of the Splitters in core use this, and I don't expect it to be used or needed in custom splitters. This commit replaces the first argument of Splitter::Base#initialize with StockLocation. Passing a Packer will work, but print a deprecation warning.
jhawthorn
force-pushed
the
splitter_chain
branch
from
ccf1194
to
e8ee9b6
Compare
mamhoff
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
Stock::Packerwas responsible for building a chain ofStock::Splitterobjects to split objects after packaging. This required some precise behaviour (like order of initialization) as well as edgecase handling (empty array of splitters) which wasn't well tested and should be outside the responsibilities of the Packer itself.This extracts the behaviour to
Spree::Stock::SplitterChain, which handles building and calling the splitters.This also changes the first argument to
Splitter::Base#initializefrom aStock::Packerto aSpree::StockLocation(with a deprecation notice).