Capitalize event buttons in OrdersHelper
#2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
reviewed
Aug 22, 2017
| @@ -6,7 +6,8 @@ def event_links | |||
| links = [] | |||
| @order_events.sort.each do |event| | |||
| next unless @order.send("can_#{event}?") | |||
| links << button_link_to(Spree.t(event), [event, :admin, @order], | |||
| links << button_link_to(Spree.t(event).capitalize, | |||
There was a problem hiding this comment.
Probably don't want to do it like this. The choice to capitalize or not is language specific, so it should exist somewhere in translations.
There was a problem hiding this comment.
Thanks John, I didn't even think about that. I'll get something else for this.
swcraig
changed the title
OrdersHelperOrdersHelper
These seem to be the only buttons that are not capitalized in the backend. They look especially weird since they can sit beside the "Resend" button which is capitalized.
swcraig
changed the title
OrdersHelperOrdersHelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seem to be the only buttons that are not capitalized in the
backend. They look especially weird since they can sit beside the
"Resend" button which is capitalized.
Edit: This only changes the translation values in
en.yml. They don't appear to be used anywhere else. The one problem with this approach is that the alert text that is generated will have the order event capitalized (e.g "Are you sure you want to Cancel this order?"). I think having an "errant" capitalization in the alert text is more desirable than lowercase button text.