Move OrdersHelper from Core to Frontend #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the OrdersHelper module from core/ to frontend/. The included methods (`order_just_completed` and `truncated_product_description`) are fairly simple and used only in the frontend. This also allows us to remove a core dependency on `truncate_html`.
This library is only used on the OrdersHelper module that was moved to frontend/ in the previous commmit.
kennyadsl
approved these changes
Jul 12, 2017
mamhoff
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove core dependency on
truncate_htmland move frontend-specific methods into the solidus_frontend gem.