Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't @extend compound selectors in sass #2073

Merged
merged 2 commits into from
Jul 11, 2017

Conversation

jhawthorn
Copy link
Contributor

The ability to extend compound selectors has been deprecated and will be removed from sass.

This fixes the following deprecation warnings

DEPRECATION WARNING on line 49 of 
Extending a compound selector, [class^="icon-"]:before, is deprecated and will not be
supported in a future release.
See https://github.com/sass/sass/issues/1599 for details.

See sass/sass#1599

@jhawthorn jhawthorn added this to the 2.3.0 milestone Jul 11, 2017
@mamhoff
Copy link
Contributor

mamhoff commented Jul 11, 2017

.flash.error apparently also counts as a compound selector.
This line still triggers that warning in the sandbox.

Otherwise, things look still good. :)

The ability to extend compound selectors has been deprecated and will be
removed from sass.

See sass/sass#1599 for details.
@jhawthorn
Copy link
Contributor Author

Good catch @mamhoff. Fixed

@jhawthorn jhawthorn merged commit 5280120 into solidusio:master Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants