Rename method_type into partial_name #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
approved these changes
Jun 2, 2017
tvdeyen
force-pushed
the
rename-method-type
branch
2 times, most recently
from
a3e8b31
to
5675a46
Compare
jhawthorn
reviewed
Jun 13, 2017
| @@ -2,7 +2,7 @@ object @order | |||
| extends "spree/api/orders/order" | |||
|
|
|||
| child :available_payment_methods => :payment_methods do | |||
| attributes :id, :name, :method_type | |||
| attributes :id, :name, :partial_name | |||
There was a problem hiding this comment.
We probably want to keep the old field around (until the next major version)
There was a problem hiding this comment.
You mean additionally? Yes, this is a good idea
tvdeyen
force-pushed
the
rename-method-type
branch
from
5675a46
to
ae0da86
Compare
|
@jhawthorn rebased on master and re-added the |
gmacdougall
approved these changes
Jun 22, 2017
|
@tvdeyen can we get a rebase on this? |
PaymentMethod#method_type is a confusing name for a method returning the name of the partial to use. As we cannot use `to_partial_path` (we use it in four different places), we use `partial_name` as more descriptive name.
tvdeyen
force-pushed
the
rename-method-type
branch
from
ae0da86
to
a6f92e6
Compare
|
@gmacdougall done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaymentMethod#method_typeis a confusing name for a method returning the name of the partial to use.As we cannot use
to_partial_path(we use it in four different places), we usepartial_nameas more descriptive name.This removes the key from the
/api/orders/:idAPI (How ever this landed up there). As I can't imagine a good approach for deprecating API keys renaming is the only option I have.