Table header fixes #1828
Merged
Table header fixes #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some table headers carry too much information in them (like the reimbursements and customer returns tables). With the recent changes we made in 0dcc028 all table headers have text wrapping disabled. We the introduction of the .wrap-text class we are able to turn text wrapping back on for certain headers.
With the recent changes to table headers in 0dcc028 text doesn’t wrap. The reimbursement and customer returns table headers carry too much information in them. Instead of rewriting these tables into forms right now, we re-enable text wrapping for this headers by using the newly introduced .wrap-text class.
With the recent changes to table headers in 0dcc028 text doesn’t wrap. The store credit table headers have long texts. We re-enable text wrapping for this headers by using the newly introduced .wrap-text class.
The bootstrap default is bottom alignment. Unfortunately there is no variable in Bootstrap to change that.
mamhoff
approved these changes
Apr 7, 2017
jhawthorn
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent changes to table headers in 0dcc028 text doesn’t wrap.
The reimbursement and customer returns table headers carry too much information in them. Instead of rewriting these tables into forms right now, we re-enable text wrapping for this headers by using the newly introduced .wrap-text class.