Fix styling of tiered promotions delete icon #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Mar 31, 2017
kennyadsl
reviewed
Mar 31, 2017
| @@ -54,9 +54,13 @@ | |||
| position: relative; | |||
| padding-bottom: 10px; | |||
|
|
|||
| >.row { | |||
Previously this trash icon was being partially obscured by the row next to it, and only the left half of the icon could be clicked. It was also floating outside of the parent container. This commit fixes these issues by adding a margin to the row, and placing the icon inside. It also changes the cursor to a pointer on hover.
jhawthorn
force-pushed
the
tiered_promotions_icon_css
branch
from
a60eabd
to
4ea4476
Compare
|
Good call @kennyadsl. We might want to add a sass linter to catch these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #1776
Previously this trash icon was being partially obscured by the row next to it, and only the left half of the icon could be clicked. It was also floating outside of the parent container. This commit fixes these issues
by adding a margin to the row, and placing the icon inside.
It also changes the cursor to a pointer on hover.
Background red showing overlap. Trash can't be clicked inside the red.