Use order instead of sort_by when getting available payment methods
#1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation of `Spree::PaymentMethod.available` used `.select` which would turn the ActiveRecord::Relation into an array and meant we had to use `sort_by`. In solidusio#1540 `available` was deprecated in favour of `available_to_users` and `available_to_admin`, each of which returns an ActiveRecord::Relation object. That means we can use `order` to do the sorting in SQL, which also allows users to chain more scopes onto the return value if they wish.
jhawthorn
approved these changes
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation of
Spree::PaymentMethod.availableused.selectwhich would turn the ActiveRecord::Relation object into an array and meant we had to usesort_byhere.In #1540
availablewas deprecated in favour ofavailable_to_usersandavailable_to_admin, each of which returns an ActiveRecord::Relation object. That means we can useorderto do the sorting in SQL, which also allows users to chain more scopes onto the return value if they wish.Note: I had to change the spec to use
eqinstead ofeql, since the latter won't do type conversions and the spec will fail because we get an ActiveRecord::Relation instead of an Array.