Do not refresh shipping rates everytime the order is viewed in the admin #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
changed the title
Mutating the order before rendering the edit form is strange. Also, rates are refreshed when customer details are changed[1] as well as when line item quantities are updated [?] and well as before the payment step. [1] https://github.com/solidusio/solidus/blob/master/backend/app/controllers/spree/admin/orders/customer_details_controller.rb#L32
mamhoff
force-pushed
the
do-not-mutate-order-on-edit
branch
from
1f3b09d
to
db8f3d6
Compare
mamhoff
changed the title
gmacdougall
approved these changes
Jun 28, 2017
jhawthorn
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutating the order before rendering the edit form is strange. Also,
rates are refreshed when customer details are changed[1] as well as before the payment step.
[1] https://github.com/solidusio/solidus/blob/master/backend/app/controllers/spree/admin/orders/customer_details_controller.rb#L32