Convert admin orders table into full width layout #1782
Conversation
The admin orders table is too narrow on modern screen sizes. There is plenty of space we could use to display the full information on the orders table. When adapting the full width layout we get too wide columns on the search form, though. This is fixed by utilizing different column sizes for the viewports. The result is pretty good without moving around any html elements (what potentially could break admin overrides of extensions or shops)
|
@Mandily please have a look at this. |
|
I'm definitely for the full width on the table. The third and fourth screenshots start to look a little odd to me with form fields moving around and empty space being on the left side of a row. Is there a way to clean that up at all without breaking extensions and shops as you mentioned above? And just to double check - is this replicable with the other listing pages as well? |
|
To play devil's advocate - did you consider putting a max width on the search area so preserve the order/groupings of form elements a little better? This was my idea in #1290 but I could see too how using less space up top could be more desirable. It also leads to the question of how well are those fields really organized at this point anyway? I wanted to move them around and even change the way a couple worked (as you can see in the checkboxes) but I was never super clear on how that would affect other stores. Any thoughts on this approach vs the full width one? |
No. We would need to move fields into other containers and this would potentially break extensions or shops.
No. Every listing page need its own treatment.
Yes, I did. I decided against because we would limit the space for potential search field additions. Some shops may add additional fields to the search form. By limiting the width we would reduce the possibility to add additional rows to that form. |
|
We definitely should reconsider the layout of that form. It is not ideal and has some elements in strange places. But: I wanted to make the changeset as small as possible. I think this is a great step forward with lots of room for improvement, sure. But better what we have right now. |
|
I agree 👍 |
tvdeyen
force-pushed
the
orders-full-width
branch
from
e688cd7
to
8b7544e
Compare
The admin orders table is too narrow on modern screen sizes. There is plenty of space we could use to display the full information on the orders table.
When adapting the full width layout we get too wide columns on the search form, though. This is fixed by utilizing different column sizes for the viewports.
The result is pretty good without moving around any html elements (what potentially could break admin overrides of extensions or shops).
Before
After