Deprecate sass variables #1780
Merged
Deprecate sass variables #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps us deprecate variables used for customizing the Solidus backend and tell users to use the Bootstrap variables instead.
In favor of Bootstraps $font-size-root we deprecate our own $body-font-size variable and align Bootstraps body style with our own.
In favor of Bootstraps $font-family-base we deprecate our own $base-font-family variable and align Bootstraps body style with our own.
In favor of Bootstraps $body-bg we deprecate our own $color-body-bg variable and align Bootstraps body style with our own.
In favor of Bootstraps $body-color we deprecate our own $color-body-text variable and align Bootstraps body style with our own.
In favor of Bootstraps link color variables we deprecate our own link color variables and align Bootstraps style with our own.
string and b are already reset by Bootstraps normalize.
And use our 3px default value in Bootstraps custom override.
In favor of Bootstraps header size variables we deprecate our own header size variables and align Bootstraps style with our own.
We and Bootstrap set header font weight. Removes our own definition and set our current default as Bootstraps default.
In favor of Bootstraps $headings-color we deprecate our own $color-headers variable and align Bootstraps body style with our own.
In favor of Bootstraps alert color variables we deprecate our own alert color variables and align Bootstraps style with our own.
mamhoff
approved these changes
Mar 20, 2017
Merged
|
Tedious one indeed!, super 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #1777 we deprecate our basic typography and colour variables and use the Bootstrap equivalent variable instead.
By dog feeding our current defaults the look is still the same as before. In future versions we will remove our variables, so extension developers and shops should start to use the Bootstrap variables instead. The depreciation warning helps by the upgrade.
I also removed some duplicated style an variable definitions that were defined by Bootstrap and us.