Fix issue where OrderInventory creates superfluous InventoryUnits #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
changed the title
|
Fixed a second issue while investigating this. Previously, when the inventory count reached This could later cause an |
jhawthorn
force-pushed
the
order_inventory_inventory_units
branch
2 times, most recently
from
d910511
to
e0fef9f
Compare
This fixes an issue where OrderInventory would miscount the number of existing inventory_units on a line item and create extra records. InventoryUnits exist through the line_item.inventory_units, shipment.inventory_units, and order.inventory_units associations. Because of this, their associations can't be kept up to date in memory. OrderInventory was counting inventory using inventory_units.size, which would return the in-memory count if the line_items.inventory_units association was loaded. This issue was exposed by adding to the same line item mutliple times without reloading the order. The line_item.inventory_units association would be become `loaded?`, because ActiveRecord's `#size` marks a record as loaded if the count returns 0 (TIL!). On the next pass it would see the wrong size because the association was out of date, and add two inventory units instead of one. This avoids the issue by counting inventory using inventory_units.count, which doesn't consider the in-memory association.
jhawthorn
force-pushed
the
order_inventory_inventory_units
branch
from
e0fef9f
to
1ae03b4
Compare
gmacdougall
approved these changes
Mar 23, 2017
mamhoff
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where OrderInventory would miscount the number of existing inventory_units on a line item and create extra records.
InventoryUnits exist through the line_item.inventory_units, shipment.inventory_units, and order.inventory_units associations. Because of this, their associations can't be kept up to date in memory.
OrderInventory was counting inventory using inventory_units.size, which would return the in-memory count if the line_items.inventory_units association was loaded.
This issue was exposed by adding to the same line item multiple times without reloading the order. The line_item.inventory_units association would be become
loaded?, because ActiveRecord's#sizemarks a record as loaded if the count returns 0 (TIL!). On the next pass it would see the wrong size because the association was out of date, and add two inventory units instead of one.This avoids the issue by counting inventory using inventory_units.count, which doesn't consider the in-memory association.