Don’t set default text highlight colors #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the problems with setting `::selection` colors is that it’s nontrivial for people who actually _want_ to use the browser-default selection colors to override the setting in a way that reverts to the browser default. For this reason I think it would be better to simply leave them out of the default `frontend` style and let individual site owners make their own decisions.
tvdeyen
approved these changes
Feb 23, 2017
jhawthorn
approved these changes
Feb 23, 2017
cbrunsdon
approved these changes
Feb 23, 2017
There was a problem hiding this comment.
Thanks @brchristian, nice to have you actually running a solidus site now :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the problems with setting
::selectioncolors is that it’s nontrivial for people who actually want to use the browser-default selection colors to override the setting in a way that reverts to the browser default. For this reason I think it would be better to simply leave them out of the defaultfrontendstyle and let individual site owners make their own decisions.