Add a frontend views override generator #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
views-generator
branch
from
07d9085
to
c287fd3
Compare
We promote overriding views instead of using Deface. This is great, but manually copying the views from GitHub or your local gem folder is tedious and error prone. By providing a generator we help our users to get the right views into their app.
tvdeyen
force-pushed
the
views-generator
branch
from
c287fd3
to
cf4f45d
Compare
mamhoff
approved these changes
Jan 11, 2017
|
Nice!!! |
gmacdougall
reviewed
Jan 17, 2017
| end | ||
|
|
||
| after do | ||
| FileUtils.rm_rf destination_root |
There was a problem hiding this comment.
What is destination_root and how comfortable are we rm -rfing it?
There was a problem hiding this comment.
It's Rails.root.join('app', 'views', 'spree') - in a spec context the views/spree directory of the dummy app, which should be empty always. I feel pretty comfortable rm-rfing :)
There was a problem hiding this comment.
Yep, destination_root is Rails' generator method that returns the path to the file destination. In this case the dummy app's app/views/spree path, that is empty anyways.
But good catch @gmacdougall !
gmacdougall
approved these changes
Feb 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We promote overriding views instead of using Deface. This is great, but manually copying the views from GitHub or your local gem folder is tedious and error prone.
By providing a generator we help our users to get the right views into their app.