Replace ShippingMethod#display_on with ShippingMethod#available_to_users #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces ShippingMethod#display_on with ShippingMethod#available_to_users to match a similar change made to payment methods. Unlike with payment_methods, this doesn't add an #available_to_admin column, because the existing functionality did not provide a way to hide shipping methods from admins. Having display_on="front_end" was identical to having display_on="both" (or actually any string other than "back_end").
jhawthorn
force-pushed
the
shipping_method_display_on
branch
from
e835cef
to
58ab9eb
Compare
cbrunsdon
approved these changes
Nov 25, 2016
Closed
tvdeyen
approved these changes
Nov 30, 2016
There was a problem hiding this comment.
Great 👍
There is this DeprecatedConstantProxy, although I doubt that anybody ever used this constant and it's safe to be used removed.
What's best here is probably to use |
tvdeyen
approved these changes
Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Echoing the work done in #1540 to PaymentMethods
This replaces
ShippingMethod#display_onwithShippingMethod#available_to_users.Unlike with payment_methods, this doesn't add an
#available_to_admincolumn, because the existing functionality did not provide a way to hide shipping methods from admins. Havingdisplay_on="front_end"was identical to havingdisplay_on="both"(or actually any string other than"back_end").