`pnpm generate` fails after clean clone due to type-only export not found at runtime

[jaydevelopsstuff]

Describe the bug

For some context, I'm looking to contribute to @solid-primitives/virtual and make it more robust for complex use cases (that I need for another project).

I'm able to clone the repo, install all packages, build, and run tests (all passed) completely fine. However, I need to be able to run the dev server to test the new features I'm adding to virtual in browser, and that's where I run into issues.

1. pnpm run dev inside packages/virtual returns this error: Error: No packages found. Did you run `pnpm generate`?.
2. Running pnpm run generate inside the root dir yields this:

user@users-MacBook-Air solid-primitives % pnpm run generate

> solid-primitives@ generate /Users/user/Documents/Coding/Web/solid-primitives
> pnpm run build && pnpm -dir site run generate


> solid-primitives@ build /Users/user/Documents/Coding/Web/solid-primitives
> node --import=@nothing-but/node-resolve-ts --experimental-transform-types ./scripts/build.ts

(node:21996) ExperimentalWarning: Type Stripping is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
esbuild step completed in 471ms.
tsc step completed in 632ms.

> site@ generate /Users/user/Documents/Coding/Web/solid-primitives/site
> node --import=@nothing-but/node-resolve-ts --experimental-transform-types ./scripts/generate.ts

(node:22019) ExperimentalWarning: Type Stripping is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
file:///Users/user/Documents/Coding/Web/solid-primitives/site/src/types.ts:1
export { FormattedBytes, ModuleData };
         ^^^^^^^^^^^^^^

SyntaxError: Export 'FormattedBytes' is not defined in module
    at compileSourceTextModule (node:internal/modules/esm/utils:344:16)
    at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:105:18)
    at ModuleLoader.<anonymous> (node:internal/modules/esm/translators:473:10)
    at #translate (node:internal/modules/esm/loader:534:12)
    at ModuleLoader.loadAndTranslate (node:internal/modules/esm/loader:581:27)

Node.js v22.17.0
 ELIFECYCLE  Command failed with exit code 1.
 ELIFECYCLE  Command failed with exit code 1.

Environment

Node (installed via nvm): v22.17.0 (tried with v24.3.0 as well, same result)
pnpm (installed via brew): 10.12.1
OS: MacOS Sequoia 15.2 Apple Silicon (M1)

Fresh Clone from main (0b567a9) with No Changes

Reproduction

I'm assuming this is an issue specific to MacOS or something along those lines as I'm sure this would have come up already if it weren't.

1. Clone fresh from main: git clone https://github.com/solidjs-community/solid-primitives
2. Install Packages cd solid-primitives && pnpm install
3. Run pnpm generate and observe the error

Note: The MRE link is the main repo because I ran into this issue simply by cloning without changing anything and running a couple commands.

Minimal Reproduction Link

https://github.com/solidjs-community/solid-primitives

[jaydevelopsstuff]

Thank you for the quick fix @thetarnav! pnpm generate and pnpm dev (inside packages/virtual) run without error now.

Unfortunately, when trying to open the resulting dev server in-browser this error is logged in the server console:

# ...

vinxi v0.5.7
vinxi starting dev server

  ➜ Local:    http://localhost:3000/
  ➜ Network:  use --host to expose

2:28:24 PM [vite] (ssr) Error when evaluating SSR module $vinxi/handler/ssr: [vite] The requested module 'solid-js' does not provide an export named 'ParentProps'
      at analyzeImportedModDifference (file:///Users/user/Documents/Coding/Web/solid-primitives/node_modules/.pnpm/vite@6.3.5_@types+node@22.15.31_jiti@2.4.2_sass@1.77.8_terser@5.42.0_tsx@4.20.2_yaml@2.5.0/node_modules/vite/dist/node/module-runner.js:530:39)
      at SSRCompatModuleRunner.processImport (file:///Users/user/Documents/Coding/Web/solid-primitives/node_modules/.pnpm/vite@6.3.5_@types+node@22.15.31_jiti@2.4.2_sass@1.77.8_terser@5.42.0_tsx@4.20.2_yaml@2.5.0/node_modules/vite/dist/node/module-runner.js:1142:56)
      at SSRCompatModuleRunner.cachedRequest (file:///Users/user/Documents/Coding/Web/solid-primitives/node_modules/.pnpm/vite@6.3.5_@types+node@22.15.31_jiti@2.4.2_sass@1.77.8_terser@5.42.0_tsx@4.20.2_yaml@2.5.0/node_modules/vite/dist/node/module-runner.js:1178:21)

It's also shown in-browser, making the intended site unviewable:

Seems to be due to the fact imports like those in packages/transition-groups/dev/switch-page.tsx, for example, are not marked with type when they should be:

import {
  Component, // Should be `type Component`
  createRenderEffect,
  createResource,
  createSignal,
  JSX,
  onCleanup,
  ParentProps, // Should be `type ParentProps`
  Show,
  Suspense,
  untrack,
} from "solid-js";
// ...
import { createSwitchTransition, TransitionMode /* Should be `type TransitionMode` */ } from "../src/index.js";

This is also from a clean clone of main on 47a9113.

[thetarnav]

I guess I need to correct more imports then. I didn't expect vite to have a problem if it doesn't use tsc.

[davey-beaver]

Hi, I think JSX also needs to be imported as type. I'm getting these errors with @solid-primitives/upload 0.1.2:

  VITE v6.3.4  ready in 259 ms

  ➜  Local:   http://localhost:3001/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
✘ [ERROR] No matching export in "node_modules/.pnpm/solid-js@1.9.7/node_modules/solid-js/dist/dev.js" for import "JSX"

    node_modules/.pnpm/@solid-primitives+upload@0.1.2_solid-js@1.9.7/node_modules/@solid-primitives/upload/dist/createFileUploader.js:1:23:
      1 │ import { createSignal, JSX } from "solid-js";
        ╵                        ~~~

✘ [ERROR] No matching export in "node_modules/.pnpm/solid-js@1.9.7/node_modules/solid-js/dist/dev.js" for import "JSX"

    node_modules/.pnpm/@solid-primitives+upload@0.1.2_solid-js@1.9.7/node_modules/@solid-primitives/upload/dist/createDropzone.js:1:23:
      1 │ import { createSignal, JSX, onCleanup, onMount } from "solid-js";
        ╵                        ~~~

✘ [ERROR] No matching export in "node_modules/.pnpm/solid-js@1.9.7/node_modules/solid-js/dist/dev.js" for import "JSX"

    node_modules/.pnpm/@solid-primitives+upload@0.1.2_solid-js@1.9.7/node_modules/@solid-primitives/upload/dist/index.js:1:9:
      1 │ import { JSX, onCleanup, onMount } from "solid-js";```

[JesseVelden]

And I got the same issue unfortunately with @solid-primitives/event-listener here:

solid-primitives/packages/event-listener/src/types.ts

Line 1 in 47a9113

import { JSX } from "solid-js";

[thetarnav]

Typescript doesn't seem to error on those for some reason so I missed them. New patches are up.

[jaydevelopsstuff]

Just opened #803 for virtual, would appreciate if someone well versed would take a look before I upgrade it from a draft to full PR.