Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seedlot Trial Filter: fix query to get stocks in trial #5228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Seedlot Trial Filter: fix query to get stocks in trial #5228

wants to merge 1 commit into from

Conversation

dwaring87
Copy link
Member

Description

This fixes a subquery in the Seedlot Trial usage filter.

It was missing stocks (plots, subplots, plants) from a trial if there were no traits observed for that stock.

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afpowell afpowell Awaiting requested review from afpowell

@alockrow alockrow Awaiting requested review from alockrow

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dwaring87