Add ability to store additionalInfo for Lists #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmueller
requested review from
lukasmueller,
nmenda and
MFlores2021
and removed request for
lukasmueller
MFlores2021
approved these changes
Sep 5, 2023
nmenda
requested changes
Sep 8, 2023
db/00168/AddCvtermForListprop.pm
Outdated
| $self->dbh->do(<<EOSQL); | ||
|
|
||
| --do your SQL here | ||
| INSERT into db (name) |
There was a problem hiding this comment.
easier to do with the built in create_with function
We are now at patch folder 00177 and 00168 already exists
db/00168/AddCvtermForListprop.pm
Outdated
| --do your SQL here | ||
| INSERT into db (name) | ||
| select 'null' where not exists( | ||
| select name from db where name = 'null' |
There was a problem hiding this comment.
I would use a different db name, maybe 'local' ?
Also need to update the system_cvterms file
https://github.com/solgenomics/sgn/blob/master/system_cvterms.txt
There was a problem hiding this comment.
Both things have been completed
|
When merged: |
timparsons
force-pushed
the
topic/BI-1642
branch
from
9571a97
to
937ade6
Compare
nmenda
approved these changes
Oct 12, 2023
timparsons
force-pushed
the
topic/BI-1642
branch
from
937ade6
to
24acf48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ability to store additionalInfo for Lists
Checklist
/t/data/fixture/patches/./docshas been updated./jsto/js/source/legacy.