Experiment & Observations import errors via BrAPI #4630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MFlores2021
reviewed
Sep 5, 2023
| } | ||
|
|
||
| my $data_out; | ||
| my $total_count=0; | ||
| # This is servicing a POST request, make sure pagination returns all created objects. | ||
| $page_size = scalar(@study_dbids); |
There was a problem hiding this comment.
looks good! Will approve when tests pass
…s endpoint, so not all created objects would be contained in the response, which is inconsistent with the BrAPI spec.
timparsons
force-pushed
the
topic/BI-1797
branch
from
70548a3
to
7c6d0c5
Compare
MFlores2021
approved these changes
Oct 12, 2023
isaak
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BreedBase was paginating its response to POST requests to the /studies endpoint, so not all created objects would be contained in the response, which is inconsistent with the BrAPI spec. Changed the pagination behavior to return all created objects, see
lib/CXGN/BrAPI/v2/Studies.pm.Checklist
/t/data/fixture/patches/./docshas been updated./jsto/js/source/legacy.