Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Field Book trait file generation when traits are created via BrAPI #4629

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Updating Field Book trait file generation when traits are created via BrAPI #4629

merged 1 commit into from
Sep 12, 2023

Conversation

timparsons
Copy link
Contributor

Description

Update the trait file generation to handle traits that were created via BrAPI

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

chris263
chris263 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@chris263 chris263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@lukasmueller lukasmueller merged commit 2ac64d3 into master Sep 12, 2023
1 check passed
@lukasmueller lukasmueller deleted the topic/BI-1752 branch September 12, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris263 chris263 chris263 approved these changes

@nmenda nmenda nmenda approved these changes

@MFlores2021 MFlores2021 Awaiting requested review from MFlores2021

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timparsons @nmenda @chris263 @lukasmueller