[zk-sdk] Remove cdylib#81
Merged
samkim-crypto merged 2 commits intoSep 25, 2025
Merged
Conversation
LucasSte
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If a crate has both cdylib declared as crate types, then we can't apply some link-time optimizations. Until recently, the
zk-sdkhad cdylib, which is required for wasm-bindgen. Now that the dependency on wasm-bindgen has been removed with #78, we can remove cdylib.Summary of Changes
Remove cdylib. I also removed the upload artifact script since we won't have .so file any more and non of the other scripts seem to depend on it.