Skip to content

Remove serde-traits feature#1137

Merged
grod220 merged 2 commits intomainfrom
serde-ft-rename
Apr 25, 2026
Merged

Remove serde-traits feature#1137
grod220 merged 2 commits intomainfrom
serde-ft-rename

Conversation

@grod220
Copy link
Copy Markdown
Member

@grod220 grod220 commented Apr 24, 2026

Follow up from: #1069 (comment). Totally unused.

Requires major version bump.

Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize that this wasn't used at all in the program -- if it's just to enable the trait on the interface crate, let's remove the feature entirely. What do you think?

@grod220
Copy link
Copy Markdown
Member Author

grod220 commented Apr 25, 2026

Oh yeah, true. Removed!

@grod220 grod220 changed the title Rename serde-traits feature to serde Remove serde-traits feature Apr 25, 2026
@grod220 grod220 requested a review from joncinque April 25, 2026 05:27
Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@grod220 grod220 merged commit 6268ab7 into main Apr 25, 2026
40 checks passed
@grod220 grod220 deleted the serde-ft-rename branch April 25, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants