This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Rpc: add getLargestAccounts endpoint#9869
Merged
Merged
Conversation
mvines
reviewed
May 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #9869 +/- ##
======================================
Coverage 80.4% 80.4%
======================================
Files 283 283
Lines 64845 64912 +67
======================================
+ Hits 52158 52239 +81
+ Misses 12687 12673 -14 |
Contributor
Author
|
@mvines , ready for another look. I decided to wrap the rpc response with context, since balances are variable, and users will likely want to know when the response data was true. |
mvines
previously approved these changes
May 4, 2020
CriesofCarrots
added
the
automerge
mergify Bot
pushed a commit
that referenced
this pull request
May 4, 2020
automerge (cherry picked from commit f5b0d13) # Conflicts: # core/src/rpc.rs
mergify Bot
pushed a commit
that referenced
this pull request
May 4, 2020
automerge (cherry picked from commit f5b0d13)
CriesofCarrots
added a commit
that referenced
this pull request
May 5, 2020
automerge (cherry picked from commit f5b0d13)
CriesofCarrots
added a commit
that referenced
this pull request
May 5, 2020
automerge (cherry picked from commit f5b0d13)
solana-grimes
pushed a commit
that referenced
this pull request
May 5, 2020
solana-grimes
pushed a commit
that referenced
this pull request
May 5, 2020
danpaul000
pushed a commit
to danpaul000/solana
that referenced
this pull request
Jul 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
People want an easy way to find the 🐳 accounts by JSON RPC.
Summary of Changes
getLargestAccountsrpc endpoint that returns the addresses and balances of the 20 accounts with the most lamports in themRewardsPools that get initialized with u64::MAX lamportsFixes #9811