This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Repair alternate versions of dead slots#9805
Merged
carllin merged 22 commits intosolana-labs:masterfrom May 5, 2020
Merged
Conversation
carllin
commented
Apr 29, 2020
carllin
commented
Apr 30, 2020
carllin
force-pushed
the
FixReplayStage2
branch
from
823f8b4 to
222cbed
Compare
Codecov Report
@@ Coverage Diff @@
## master #9805 +/- ##
========================================
- Coverage 80.4% 80.3% -0.1%
========================================
Files 283 283
Lines 64977 65564 +587
========================================
+ Hits 52243 52689 +446
- Misses 12734 12875 +141 |
sakridge
reviewed
Apr 30, 2020
sakridge
reviewed
Apr 30, 2020
sakridge
reviewed
Apr 30, 2020
ryoqun
reviewed
May 1, 2020
ryoqun
reviewed
May 1, 2020
ryoqun
reviewed
May 1, 2020
ryoqun
reviewed
May 1, 2020
ryoqun
reviewed
May 1, 2020
ryoqun
reviewed
May 1, 2020
ryoqun
reviewed
May 2, 2020
ryoqun
reviewed
May 4, 2020
ryoqun
reviewed
May 4, 2020
ryoqun
reviewed
May 4, 2020
aeyakovenko
reviewed
May 4, 2020
Member
aeyakovenko
left a comment
aeyakovenko
left a comment
There was a problem hiding this comment.
can you schedule something to walk me through the code?
ryoqun
reviewed
May 5, 2020
ryoqun
reviewed
May 5, 2020
ryoqun
previously approved these changes
May 5, 2020
Contributor
There was a problem hiding this comment.
LGTM with nits; I did full-blown code review!
I say this is good to merge, although @aeyakovenko might have something to say according to
#9805 (review)
Contributor
Author
|
@ryoqun thanks for the detailed review! |
… drop the slot anyways in repair logic
solana-grimes
removed
the
automerge
Contributor
|
💔 Unable to automerge due to CI failure |
mergify Bot
pushed a commit
that referenced
this pull request
May 5, 2020
Co-authored-by: Carl <carl@solana.com> (cherry picked from commit 3442f36) # Conflicts: # runtime/src/accounts_db.rs
solana-grimes
pushed a commit
that referenced
this pull request
May 6, 2020
carllin
added a commit
to carllin/solana
that referenced
this pull request
May 7, 2020
…solana-labs#9886)" This reverts commit e85f9fc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some validators were getting stuck on a slot on the main fork(invalid entry hash) if they got conflicting shreds for the same slot.
#9369
Summary of Changes
Check ClusterSlots to see if supermajority has completed a slot that was marked dead. If so:
Fixes #
#9369