Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and update tests #9566

Merged
merged 1 commit into from
Apr 19, 2020
Merged

Add and update tests #9566

merged 1 commit into from
Apr 19, 2020

Conversation

jackcmay
Copy link
Contributor

@jackcmay jackcmay commented Apr 17, 2020 •
edited
Loading

Problem

  • Missing BPF_loader tests
  • Copypasta in runtime tests

Summary of Changes

Add and cleanup

Fixes #

@jackcmay jackcmay added the automerge Merge this Pull Request automatically once CI passes label Apr 17, 2020
@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Apr 17, 2020
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

@jackcmay jackcmay added the automerge Merge this Pull Request automatically once CI passes label Apr 17, 2020
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Apr 18, 2020
@jackcmay jackcmay added the automerge Merge this Pull Request automatically once CI passes label Apr 18, 2020
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Apr 18, 2020
@jackcmay jackcmay added the automerge Merge this Pull Request automatically once CI passes label Apr 18, 2020
@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Apr 18, 2020
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #9566 into master will increase coverage by 0.0%.
The diff coverage is 83.7%.

@@          Coverage Diff           @@
##           master   #9566   +/-   ##
======================================
  Coverage    80.6%   80.6%           
======================================
  Files         279     279           
  Lines       63381   63473   +92     
======================================
+ Hits        51113   51209   +96     
+ Misses      12268   12264    -4

@jackcmay jackcmay merged commit 58887c5 into solana-labs:master Apr 19, 2020
@jackcmay jackcmay deleted the tests branch April 19, 2020 00:04
@Digiminey Digiminey mentioned this pull request Dec 14, 2023
Open
@masakazu12 masakazu12 mentioned this pull request Dec 14, 2023
Open
@adamlaska adamlaska mentioned this pull request Dec 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackcmay @solana-grimes