Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

94: source doc review#95

Merged
garious merged 2 commits intosolana-labs:masterfrom
jackson-sandland:source-documentation-review
Mar 30, 2018
Merged

94: source doc review#95
garious merged 2 commits intosolana-labs:masterfrom
jackson-sandland:source-documentation-review

Conversation

@jackson-sandland
Copy link
Copy Markdown
Contributor

formats module descriptions

Copy link
Copy Markdown
Contributor

@garious garious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks!

Comment thread src/accountant_skel.rs Outdated
@@ -1,6 +1,6 @@
//! The AccountantSkel is a microservice that exposes the high-level
//! The `accountantSkel` module is a microservice that exposes the high-level
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be snake_case

Comment thread src/accountant_stub.rs Outdated
@@ -1,4 +1,4 @@
//! A AccountantStub is client-side object that interfaces with a server-side Accountant
//! The `accountantStub` module is a client-side object that interfaces with a server-side Accountant
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 30, 2018

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files          15       15           
  Lines        1145     1145           
=======================================
  Hits         1074     1074           
  Misses         71       71
Impacted Files Coverage Δ
src/ledger.rs 100% <ø> (ø) ⬆️
src/result.rs 89.04% <ø> (ø) ⬆️
src/streamer.rs 91.98% <ø> (ø) ⬆️
src/historian.rs 100% <ø> (ø) ⬆️
src/plan.rs 99% <ø> (ø) ⬆️
src/accountant_stub.rs 95.23% <ø> (ø) ⬆️
src/entry.rs 94.28% <ø> (ø) ⬆️
src/accountant.rs 94.81% <ø> (ø) ⬆️
src/hash.rs 100% <ø> (ø) ⬆️
src/accountant_skel.rs 92.79% <ø> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaec25f...9f256f0. Read the comment docs.

@garious garious merged commit 54e4f75 into solana-labs:master Mar 30, 2018
@jackson-sandland jackson-sandland deleted the source-documentation-review branch March 31, 2018 00:20
vkomenda referenced this pull request in vkomenda/solana Aug 29, 2021
Bumps [superstruct](https://github.com/ianstormtaylor/superstruct) from 0.8.4 to 0.10.12.
- [Release notes](https://github.com/ianstormtaylor/superstruct/releases)
- [Changelog](https://github.com/ianstormtaylor/superstruct/blob/master/Changelog.md)
- [Commits](ianstormtaylor/superstruct@v0.8.4...v0.10.12)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
joncinque pushed a commit to joncinque/agave that referenced this pull request Mar 6, 2024
* Simplify vote-authority display

* Add handling for new vote authority

* Add proper None handling, because unit test (shouldn't happen IRL, though)

* Unwrap->expect
willhickey pushed a commit that referenced this pull request Mar 9, 2024
* Simplify vote-authority display

* Add handling for new vote authority

* Add proper None handling, because unit test (shouldn't happen IRL, though)

* Unwrap->expect
segfaultdoc pushed a commit to jito-labs/solana that referenced this pull request Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants