calculate ref counts earlier to prevent bad clean

[sakridge]

Problem

Storage ref counts can prevent an account from being cleaned, but that also affects if another item would be cleaned. We don't go back and update the storage counts of those other items.

Summary of Changes

Calculate ref counts in earlier loop which does re-calculate the storage counts.

Fixes #9137

[ryoqun]

if possible, we'd like to have a test for this although writing one would be cumbersome as this is a bit a corner case.

[ryoqun]

@mvines Good news! I think this fixes yesterday's snapshot error with highly-likely chance. it seems that @sakridge and I independently reached to the same root cause and fix for it, although @sakridge was a ahead than me. ;)

[codecov]

Codecov Report

Merging #9147 into master will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master   #9147     +/-   ##
========================================
- Coverage    80.5%   80.5%   -0.1%     
========================================
  Files         271     271             
  Lines       59610   59611      +1     
========================================
  Hits        48026   48026             
- Misses      11584   11585      +1     

[ryoqun]

LGTM! Thanks for cleaning up the logic!