Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Use 1gb as genesis limit to fix bench-tps ledger from not starting#9133

Merged
solana-grimes merged 1 commit intosolana-labs:masterfrom
sakridge:allow-bigger-genesis
Mar 27, 2020
Merged

Use 1gb as genesis limit to fix bench-tps ledger from not starting#9133
solana-grimes merged 1 commit intosolana-labs:masterfrom
sakridge:allow-bigger-genesis

Conversation

@sakridge
Copy link
Copy Markdown
Contributor

Problem

validators won't accept a huge genesis as generated by bench-tps

Summary of Changes

Up the limit to 1gb which is still reasonable, but allwos for bench-tps to run.

Fixes #

@sakridge sakridge requested review from danpaul000 and ryoqun March 27, 2020 22:48
@danpaul000
Copy link
Copy Markdown
Contributor

Do we want to allow this blanket size increase across the board, or just until we have a more flexible solution to allow for the test environment?

@mvines
Copy link
Copy Markdown
Contributor

mvines commented Mar 27, 2020

or just until we have a more flexible solution to allow for the test environment?

Ya, this

@sakridge
Copy link
Copy Markdown
Contributor Author

or just until we have a more flexible solution to allow for the test environment?

Ya, this

Yea, this is just to unblock these runs while we can work on plumbing an option for the real environment.

@sakridge sakridge added the automerge Merge this Pull Request automatically once CI passes label Mar 27, 2020
@solana-grimes solana-grimes merged commit 2863f8e into solana-labs:master Mar 27, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b7b4aa5). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #9133   +/-   ##
========================================
  Coverage          ?   80.4%           
========================================
  Files             ?     270           
  Lines             ?   58967           
  Branches          ?       0           
========================================
  Hits              ?   47452           
  Misses            ?   11515           
  Partials          ?       0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants