This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Bitwise compress incomplete epoch slots#8341
Merged
pgarg66 merged 1 commit intoFeb 20, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8341 +/- ##
========================================
+ Coverage 80.5% 80.5% +<.1%
========================================
Files 253 253
Lines 55412 55416 +4
========================================
+ Hits 44637 44642 +5
+ Misses 10775 10774 -1 |
Contributor
|
This needs to be backported to 0.23 since it's an ABI change to Gossip, and thus must be picked up when we restart TdS |
mergify Bot
pushed a commit
that referenced
this pull request
Feb 20, 2020
(cherry picked from commit ea8d9d1) # Conflicts: # core/src/cluster_info.rs # core/src/crds_value.rs
Contributor
Author
pgarg66
referenced
this pull request
in pgarg66/solana
Feb 20, 2020
pgarg66
added a commit
that referenced
this pull request
Feb 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Incomplete slot information in
EpochSlotscould cause the message to grow larger than MTU size. The current message format is not ABI forward compatible with changes required to split it in MTU sized chunks.Summary of Changes